Tweak: Move App Password badge to User column - #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Move the App Password badge from the Source column to the User column for better UX clarity—app authentication method is user-centric, not source metadata.
2. What Changed (Where)
app_passwordcolumn case into_export_row()format_source_label_plain()output3. How It Works
When rendering a log row,
app_passwordis now extracted directly fromrequest_sourceviaAAL_API::parse_request_source()and rendered as a small badge beneath the user's role in the User column—no longer mixed into the Source column's channel/IP display.4. Risks
None identified. Column reordering is transparent to consumers; badge relocation is UI-only; tests validate both cases (with app vs. REST without app).
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how