Skip to content

Tweak: Move App Password badge to User column - #242

Merged
KingYes merged 1 commit into
masterfrom
tweak/move-app-pass-column
Sep 1, 2026
Merged

Tweak: Move App Password badge to User column#242
KingYes merged 1 commit into
masterfrom
tweak/move-app-pass-column

Conversation

@KingYes

@KingYes KingYes commented Sep 1, 2026

Copy link
Copy Markdown
Member

✨ PR Description

1. Problem & Context

Move the App Password badge from the Source column to the User column for better UX clarity—app authentication method is user-centric, not source metadata.

2. What Changed (Where)

  • Export logic: Reordered columns array; added dedicated app_password column case in to_export_row()
  • Source formatting: Removed app name from format_source_label_plain() output
  • UI: Relocated app badge rendering from Source cell to User cell; adjusted badge base styles (font sizing)
  • Tests: Added two test cases validating app password column exports with/without app name

3. How It Works

When rendering a log row, app_password is now extracted directly from request_source via AAL_API::parse_request_source() and rendered as a small badge beneath the user's role in the User column—no longer mixed into the Source column's channel/IP display.

4. Risks

None identified. Column reordering is transparent to consumers; badge relocation is UI-only; tests validate both cases (with app vs. REST without app).

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@KingYes
KingYes merged commit a92422c into master Sep 1, 2026
54 checks passed
@KingYes
KingYes deleted the tweak/move-app-pass-column branch September 1, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant